Improved detection of line endings in ChunkBuffer #42
Conversation
Added carriage return + line feed (\n\r) as possible line ending to 'readLine()'
|
@jordancamara can you take a look at this? |
|
Is there someone with write access? If so i will update the PR. |
|
It seems like everyone with write access have gone silent. I'd love to see this merged. It solved an issue for me. |
|
Seems like I don't have the rights to merge too, I would like someone to update the pods too, to fix some bugs Starscream. May be forking is the only way for now |
|
I have updated this and the other pull request into my fork, and updated the pods too. I didn't test much, though everything seems to work fine. Not much changes in the code, however I will be testing all the new changes this week. If anyone finds an issue then please let me know. |
|
Shouldn't it be |
|
still issue is there. |
|
Objective C code working in swift (using bridge header) - No reconnection issues and other. Dear @auther please check on swift version. Thank for your help |
Added carriage return + line feed (\n\r) as possible line endings to 'readLine()'.
Otherwise if the server delivers a response like:
data: {...}\n\r data: {}the response cannot be parsed correctly in 'ServerSentEventsTransport.open()'